how do i simplify this snippet?

what im trying to do is make the code easier to work with by stopping repition of certain lines of code. i have gotten rid of the extra ones but now when say you are user level 5 it only shows those links when it shold show all of them :

Code:

<?php
$new = mysql_query("select * from pmessages where unread = 'unread' and touser = '$logged[username]'"); 
$new = mysql_num_rows($new); 
echo("<b><div style=\"font-size: 8pt\">Control Panel</b><br>");
 if ($logged[username] && $logged[level] == 5) {echo("
-<a href=\"?open=12\">User Manager</a><br>
-<a href=\"?open=22\">Page Editor</a><br>
-<a href=\"?open=11\">News Manager</a><br>
-<a href=\"?open=15\">Link Manager</a><br>");
}elseif ($logged[username] && $logged[level] >= 2) {echo("
-<a href=\"?open=10\">Submit Link</a><br>
-<a href=\"?open=14\">Modify Link</a><br>");
}elseif ($logged[username] && $logged[level] >= 1) {echo("
-<a href=\"?open=7\">Edit Profile</a><br>
-<a href=\"?open=8\">Change Password</a><br>
-<a href=\"?open=9&page=inbox\">Private Messages ($new new)</a><br>
-<a href=\"?open=20\">Logout</a></div>");
}else{ echo "<div align=\"center\" style=\"font-size: 8pt\">"; include('login.php'); echo "</div>";}?>

[SEO Voter]

Try this ...

Code:

<?php

$new = mysql_query("select * from pmessages where unread = 'unread' and touser = '$logged[username]'");
$new = mysql_num_rows($new);

echo("<b><div style=\"font-size: 8pt\">Control Panel</b><br>");

if ($logged[username] && $logged[level] == 5) 
{
echo("
-<a href=\"?open=12\">User Manager</a><br>
-<a href=\"?open=22\">Page Editor</a><br>
-<a href=\"?open=11\">News Manager</a><br>
-<a href=\"?open=15\">Link Manager</a><br>");
}

if ($logged[username] && ($logged[level] >= 2 || $logged[level] >= 5)) 
{
echo("
-<a href=\"?open=10\">Submit Link</a><br>
-<a href=\"?open=14\">Modify Link</a><br>");
}

if ($logged[username] && ($logged[level] >= 1 || $logged[level] >= 5))  
{
echo("
-<a href=\"?open=7\">Edit Profile</a><br>
-<a href=\"?open=8\">Change Password</a><br>
-<a href=\"?open=9&page=inbox\">Private Messages ($new new)</a><br>
-<a href=\"?open=20\">Logout</a></div>");
}

if (!$logged[username])
{ 
echo "<div align=\"center\" style=\"font-size: 8pt\">"; 
include('login.php'); 
echo "</div>";
}

?>

yeah it seems to work pretty nicely now, here is what ive got:

Code:

<?php
$new = mysql_query("select * from pmessages where unread = 'unread' and touser = '$logged[username]'"); 
$new = mysql_num_rows($new); 

if ($logged[username] && $logged[level] == 5) {$rank = "Admin";} 
elseif ($logged[username] && $logged[level] == 2) {$rank = "Customer";} 
else {$rank = "User";}


if ($logged >= 1) {echo("<b><div style=\"font-size: 8pt\">$rank Control Panel</b><br>");

 if ($logged[username] && $logged[level] == 5) {echo("
-<a href=\"?open=12\">User Manager</a><br>
-<a href=\"?open=22\">Page Editor</a><br>
-<a href=\"?open=11\">News Manager</a><br>
-<a href=\"?open=15\">Link Manager</a><br>");}

if ($logged[username] && ($logged[level] >= 2 || $logged[level] >= 5))  {echo("
-<a href=\"?open=10\">Submit Link</a><br>
-<a href=\"?open=14\">Modify Link</a><br>");}
if ($logged[username] && ($logged[level] >= 1 || $logged[level] >= 5))  {

echo("-<a href=\"?open=7\">Edit Profile</a><br>
  -<a href=\"?open=8\">Change Password</a><br>
  -<a href=\"?open=9&page=inbox\">Private Messages ($new new)</a><br>
  -<a href=\"?open=20\">Logout</a></div>");}
}else{ echo "<div align=\"center\" style=\"font-size: 8pt\">"; include('login.php'); echo "</div>";}?>

[Join us @ facebook]

A small tip.

When you are about to print html, you can use something like

echo '<a href="fdfdfdf">';

This way you wont have to put the \" brackets.

[SEO Voter]

or...

echo "<a href='fdfdfdf'>";

either one of these is much easier than using \" all the time.

ya ihave tried both of those methods they all work the same way right?

[SEO Voter]

Basically, but at least you don't have to use the backslash (\)...

i am still wondering how to let users have more then 1 link ... as-is now i have to manually change their level to 2 and url ID to whatever it is their link will be, after they have paid.. this is slow but getting faster process anyway.. i cant figure how how i will add more then 1 value to the row "urlid" for each user if necessary

[Join us @ facebook]

If I understand right what you say, you should have different tables for the users and for the sites.

Each site row will have a userID field. Then you will have to use the INNER JOIN statement to retrieve the data.

yes the links themselves, and user date (like password) are different tables..so i should get rid of current row on user table "urlid" and add new one to links table as "userid"? this will screw up the current way i have it set up lol

[Join us @ facebook]

But it is the correct way. While you will be able to have more urls per user. Now you can have more users per url which is ofcourse wrong.

ok users table has row : urlid. i delete that right, then create new row on links "urlid"? it already has the row "id" which is auto_inc

[Join us @ facebook]

Yes you create a new row userId in the url table that points to the user.id field

what do you mean points to user.id field? lol i think u have slightly confused me now haha

[Join us @ facebook]

I told that meaning the relation of those fields

[Guest]

[36.904]

Googlebot, Yahoo crawler, Baidu Spider