Recursive function

[web directory]

Hi Guys,

It has been a long day and I think that I have been staring at this 24" LCD too long

Have a look at this code and see if you can see anything wrong with it and if you can improve... I am trying to get the function to return an array of category ID's, but have ended up trying to get it to work using a string; but even that is not working! Grrr...

Code:

<?php
function getDirCrumbIDs($catID, $str = null)
{
   global $db;

   $sql = "select * from category where categoryid = '$catID' limit 1";

   if ($row = $db->get_row($sql))
   {
      getDirCrumbIDs($row->CategoryParentID, "$catID|".$str);
   }

   return $str;
}

echo getDirCrumbIDs($_GET['cat']);

?>

Trying to just echo the returned string, but it is outputting nothing. If I echo the $str in the function as it runs through all the categories, it definitely prints the correct values. The last echo is just not outputting anything.

Any ideas?

[Join us @ facebook]

That's because the last record has no parent. Right?

(I am out of office right now, and I couldn't take a closer look)

[web directory]

If I add "echo $str;" before the line that returns $str it echos out a value that I can use, but it is not echoing it out on the last echo...

[Join us @ facebook]

Try this :

Code:

<?php
function getDirCrumbIDs($catID, $str = null)
{
   global $db;

   $sql = "select * from category where categoryid = '$catID' limit 1";

   if ($row = $db->get_row($sql))
   {
      getDirCrumbIDs($row->CategoryParentID, "$catID|".$str);
      return $str;
   }
}

echo getDirCrumbIDs($_GET['cat']);

?>

[web directory]

Nothing happens this way either... I think that way you have it, the function will never return a value.

[Join us @ facebook]

Hmm, it's not my day

I will check it again later. Recursive functions were never something that I was good.....

[web directory]

I have altered it to a methid that works but I think that it really the best way of doing it...

Code:

<?php

function getDirCrumbIDs($catID)
{
   global $db;

   $sql = "select * from category where categoryid = '$catID' limit 1";

   if ($row = $db->get_row($sql))
   {
       $string .= "$catID|";
       $string .= getDirCrumbIDs($row->CategoryParentID);
   }

   return $string;
}

echo getDirCrumbIDs($_GET['cat']);

If anyone can comment on this method, please do so. It works but I just feel that it is an improper method...

Thanks!

... and thanks Nick for looking at it!

[Guest]

[62.861]

Googlebot, Yahoo crawler