set item as completed

trying to make it so i can set these things to do as completed by clicking a link.. im pretty sure i have done most of it right and it says taht it successfully marked it as complete, but it doesnt. thing_status stays at 0 when it should be 1:

list of things with link to complete it

Code:

<?php
echo "<center>";

$result2 = dbquery("SELECT * FROM fusion_things2do_cats ORDER BY cat_id");
while ($data2 = dbarray($result2))
{
   $result = dbquery("SELECT * FROM fusion_things2do WHERE thing_cat = " . $data2['cat_id']);
   while ($data = dbarray($result))
   {
echo $data['thing_id'];
echo ". <b>".$data['thing_name']."</b><br>";
echo "<i>Item Category: ".$data2['cat_name']."</i><br>";
echo $data['thing_description']; 
echo "<br><br>";
if ($data['thing_status'] == 0){
echo "[<a href='done_thing.php".$aidlink."&amp;cmd=completed&amp;thing_id=".$data['thing_id']."'>Mark As Completed</a>]<br><hr width='30%'><br>";
} else { 
echo "<font color='yellow' weight='bold'>Item Completed.</font><br><hr width='30%'><br>"; 
}
}
}
echo "</center>";
?>

this is the page that performs the complete command

Code:

<?php
require_once "../maincore.php";
require_once BASEDIR."subheader.php";
require_once ADMIN."navigation.php";

if (!checkrights("KA") || !defined("iAUTH") || $aid != iAUTH) fallback("../index.php");
opentable('Set Thing to Do as Complete');

if($_GET["cmd"]=="completed")
{
$getcompleted = mysql_query("SELECT * from fusion_things2do order by thing_id asc"); 
while($data = mysql_fetch_array($getcompleted)) 
{ 
if(!isset($cmd)) 
{
$result = mysql_query("UPDATE fusion_things2do SET thing_status = 1 WHERE thing_id = " . $data['thing_id']); 
while($r=mysql_fetch_array($result)) 
{ 
$thing_id=$r['thing_id'];
     }
}
}
    $sql = "SELECt * FROM fusion_things2do WHERE thing_id=$thing_id";
    $result = mysql_query($sql);
    echo "<center>Thing to Do has been marked as completed!<br><br>Click [<a href='".BASEDIR."administration/things_todo.php".$aidlink."'>here</a>] to return to the Things to Do.</center>";
}
closetable();


require_once BASEDIR."footer.php";
?>

[Join us @ facebook]

In a first sight, I think this line has the problem :

if(!isset($cmd))

what is wrong with it i use similair approach to delete a thing to do and it works fine

[Join us @ facebook]

The $cmd variable is not seted anywhere.

So is allways false => so it will never execute the UPDATE sql statement.

how do i fix this problem im totally confused once again

[Join us @ facebook]

I guess if you just remove this if statement it will work

when i run it, it sets all things to status 1, when it should only set the thing that i clicked on to 1..

Code:

<?php
require_once "../maincore.php";
require_once BASEDIR."subheader.php";
require_once ADMIN."navigation.php";

if (!checkrights("KA") || !defined("iAUTH") || $aid != iAUTH) fallback("../index.php");
opentable('Set Thing to Do as Complete');

if($_GET["cmd"]=="completed")
{
$getcompleted = mysql_query("SELECT * from fusion_things2do order by thing_id asc"); 
while($data = mysql_fetch_array($getcompleted)) 
{ 
//if(!isset($cmd)) 
//{
$result = dbquery("UPDATE fusion_things2do SET thing_status = 1 WHERE thing_id = " . $data['thing_id']); 
while($r=dbarray($result)) 
{ 
$thing_id=$r['thing_id'];
     }
//}
}
    $sql = "SELECt * FROM fusion_things2do WHERE thing_id=$thing_id";
    $result = mysql_query($sql);
    echo "<center>Thing to Do has been marked as completed!<br><br>Click [<a href='".BASEDIR."administration/things_todo.php".$aidlink."'>here</a>] to return to the Things to Do.</center>";
}
closetable();


require_once BASEDIR."footer.php";
?>

[Join us @ facebook]

Then propably the whole thing is wrong.

You shouldn't do anyother query except something like this :

$result = dbquery("UPDATE fusion_things2do SET thing_status = 1 WHERE thing_id = " . $_POST['id']);

where $_POST['id'] supposed to be the user you clicked on.

[Guest]

[62.873]

deccanbazaar, Googlebot, adsense, Msnbot, hobbit, Yahoo crawler