can this be simplified?

this is kind of sloppy i think. i am sure there is a better way to determine this:

Code:

<?php

if ($melee_combat > $range_combat) 
{ $class_combat = $melee_combat; }
elseif ($melee_combat > $mage_combat) 
{ $class_combat = $melee_combat; } 
elseif ($range_combat > $melee_combat) 
{ $class_combat = $range_combat; } 
elseif ($range_combat > $mage_combat) 
{ $class_combat = $range_combat; } 
elseif ($mage_combat > $melee_combat) 
{ $class_combat = $mage_combat; } 
elseif ($mage_combat > $range_combat) 
{ $class_combat = $mage_combat; }

?>

It's kind of hard to understand what you want to do exactly. Try this: tell us in simple steps what you want to do (in plain English) from that we can make your code (probably using case)

One thing I quickly notice:

Code:

<?php

if ($melee_combat > $range_combat) 

elseif ($range_combat > $melee_combat) 

?>

the second has to be true, if the first statement wasn't, so it can be ignored (unless they are the same value, which you are not checking for any of the variables...)

Oke, I think I see what you want to do: you have 3 variables and you want $class_combat to have the value of the variable with the highest value of the 3 right? Try this:

Code:

<?php

$class_combat = $mage_combat;
if($range_combat > $class_combat)
{$class_combat = $range_combat;}
if($melee_combat > $class_combat)
{$class_combat = $melee_combat;}

?>

[Join us @ facebook]

Or put all those values in an array, sort them and get the biggest value (but maybe this would be slower.....)

Or put all those values in an array, sort them and get the biggest value (but maybe this would be slower.....)

this is more the answer i was looking for.. so i would store them in an array then select the MAX value?

[Join us @ facebook]

I would say try Mind_nl's way better

the method he proposed last will not work, because you say class combat = mage combat at first, so the rest of the if/else is irrelevant.. we ahve 3 variables, mage combat, range combat, and melee combat. we want to find the highest value of those 3 and set that to be the class combat

thats exactly what its doing, you set it to the first value first and then override this value if the other turns out to be bigger. The if's are comparing your variable with whats in $class_combat at the time

so you do not think using an array would be better?

Like Nikolas said, the array way would probably be slower. You have to create the array, fill it, sort it and extract the highest value. This will cause some overhead. Probably not noticable in this case but still.
Heres another way I found which is even more elegant:

Code:

<?php

$class_combat = MAX($mage_combat,MAX($range_combat,$melee_combat));

?>

Now that's some compact coding right there! 

yes buddy thats exactly what im talking about.. thank you.. i mentioned MAX earlier!

[Guest]

[62.870]

Googlebot, hobbit, Yahoo crawler, AndyPR, hirewebdesigner