(The user thought that is) Another bug fix

OK, found another potential bug/undocumented feature.

In the function create_form_field, change

Code:

if (isset($_REQUEST[$formelement])) {
$form_field .= $_REQUEST[$formelement];
}

to

Code:

if (isset($_REQUEST[$formelement])) {
$form_field .= htmlspecialchars($_REQUEST[$formelement], ENT_QUOTES);
}

OK, found another potential bug/undocumented feature.

In the function create_form_field, change

Code:

if (isset($_REQUEST[$formelement])) {
$form_field .= $_REQUEST[$formelement];
}

to

Code:

if (isset($_REQUEST[$formelement])) {
$form_field .= htmlspecialchars($_REQUEST[$formelement], ENT_QUOTES);
}

OK, and why do you think that this is a bug? it works fine without "htmlspecialchars"

a bug is about somthing that doesn't work right, you are accepting somthing different, thats called suggesting an approvement

and at the end the test is not OK, better is

if (!empty($_REQUEST['var'])) {...

hehe

haha, you're the one that used that test in the first place.

having htmlspecialchars just makes sense though. If the person uses a quote or something else, the new page WILL break, and leave a bad impression. Best to make it a little more foolproof.

haha, you're the one that used that test in the first place.

having htmlspecialchars just makes sense though. If the person uses a quote or something else, the new page WILL break, and leave a bad impression. Best to make it a little more foolproof.

Of course your suggestion is not bad but don't tell people that this is a bug while it's based on you personal opinion.
At the end this small details are up to the user, believe me if I use this class for a wide public I use more validation than only some basic html function. Check this class for real validation: http://www.finalwebsites.com/snippets.php?id=15

[Guest]

[62.883]

w66266507, adsense