Calling Two Different Functions onSubmit

[Philippine Beach Resorts]

guys, here i go again:

i have two functions i want to call when my user clicks the submit button in my form. how should i do it? here is the code i found on the web:

Function 1

Code:

<script>

/*
Check required form elements script-
By JavaScript Kit (http://javascriptkit.com)
Over 200+ free scripts here!
*/

function checkrequired(which){
var pass=true
if (document.images){
for (i=0;i<which.length;i++){
var tempobj=which.elements[i]
if (tempobj.name.substring(0,8)=="required"){
if (((tempobj.type=="text"||tempobj.type=="textarea")&&tempobj.value=='')||(tempobj.type.toString().charAt(0)=="s"&&tempobj.selectedIndex==-1)){
pass=false
break
}
}
}
}
if (!pass){
alert("One or more of the required fields are not completed. Please complete them, then submit again!")
return false
}
else
return true
}
</script>

onSubmit="return checkrequired(this)"

Function 2

Code:

function onSubmitForm( f, ext ){
//(C)2006 Stephen Chalmers

var badName="", allBlank=true, rx;

rx=new RegExp("[^\.]\."+ext+"\s*$", "i");

for( var i=0,e=f.elements; i<e.length; i++ )
{
if( e[i].type=='file' )
{
e[i].value=e[i].value.replace(/^\s+/,'').replace(/\s+$/,'');

if( e[i].value.length )
{
allBlank=false;
if( !rx.test(e[i].value) )
badName+='\n\n' + e[i].value;
}
}
}

if( allBlank )
alert("Please click on 'Browse' and select a file to upload.")
else
if( badName )
alert( 'A required .'+ext+' extension was not found in:' + badName );

return (badName || allBlank) ? false : true;
}

onSubmit="return onSubmitForm(this, [\'gif\', \'jpg\', \'jpeg\'])"

i wish to validate some required fields and the file name of the photo they will upload.

create a third function that calls the other two

[Philippine Beach Resorts]

Code:

function Third {
var Rtn = true;
Rtn = checkrequired(this);
if (Rtn) {
Rtn = onSubmitForm(this, ['gif', 'jpg', 'jpeg']);
}
return Rtn;
}

onSubmit="return Third()"

i tried this but it didnt work. please correct it.

just read your full post

I think you can't validate the filename before upload.

but why not validating the whole thing on the server site (using php)?

check this demo:
http://www.finalwebsites.com/demos/php_file_upload.php

[Philippine Beach Resorts]

the two functions work separately but when i call the two, it doesnt anymore. is there anything wrong with the code?

the two functions work separately but when i call the two, it doesnt anymore. is there anything wrong with the code?

i think the problem is this, btw you need these functions together like:
if all fields are valid then validate the file name...

[Philippine Beach Resorts]

tried it on my own but i wasnt able to make it work. any help with the code for combining or calling the two functions at the same time will be very much appreciated!

[Join us @ facebook]

First of all, can you explain what exactly do you want to do?

First of all, can you explain what exactly do you want to do?

he is trying something similar to my demo link

[Philippine Beach Resorts]

thanks. i just want to validate a form for the required fields and the file name of the photos to be uploaded just using javascript. i cant do it server side because i already have php functions implemented and i dont want to complicate it further, me not being a programmer...

[Join us @ facebook]

Validate the file name against what? If the file is not empty, then it is correct, right?

[Philippine Beach Resorts]

if they are submitting the right file format: jpeg, jpg, gif, png... and they are filling the required fields before it gets sent to my server.

if they are submitting the right file format: jpeg, jpg, gif, png... and they are filling the required fields before it gets sent to my server.

maybe you should post the existing php code, adding the two rows for validation is much easier then writing some new JS function

[Philippine Beach Resorts]

thanks man. i decided to just convert whatever file they uploaded into a jpeg file.

thanks man. i decided to just convert whatever file they uploaded into a jpeg file.

yeah use imagemagicks (but you need to prevent the upload of dangerous files (scripts))

[Philippine Beach Resorts]

even if i convert those dangerous file or scripts into .jpeg file, are they still dangerous?

even if i convert those dangerous file or scripts into .jpeg file, are they still dangerous?

I guess this should be answered by a Linux guru

[Join us @ facebook]

As far as I know nothing is dangerous unless you do it

If you are moving the files to a standard directory, and you are not using those files to run code (which would be impossible with php anyway) you wont have any problems.

[Philippine Beach Resorts]

thanks for the help!

As far as I know nothing is dangerous unless you do it

If you are moving the files to a standard directory, and you are not using those files to run code (which would be impossible with php anyway) you wont have any problems.

so I cant run a (risky) script via the browser like http://www.domain.com/dir/somescript.jpg?

[Guest]

[62.885]

Googlebot, Yahoo crawler