help on download script

hi all, newbie here.... first, thanks Olaf for sharing this upload/download script which i am tinkering at www.alphabet-ny.com/clientLogin/page.php . the uploading part runs OK but i am lost why it can't run the download part. it will show an error message on the browser if it has an error right? but i only see a blank page and nothing is downloading. hope somebody can point me where to find solution for this.  btw, i tested the scripts to a different server and uploading/downloading files were OK.

thanks in advance! 

[Free WordPress Themes]

whats your download code?

here is the download.php Olaf, i didnt really changed much from the original code.

<?php
$folder = $_SERVER['DOCUMENT_ROOT']."/clientLogin/files/";

if (isset($download)) {
    $fullPath = $folder.$_POST['file_in_folder'];
   
    if ($fd = fopen ($fullPath, "r")) {
        $fsize = filesize($fullPath);
        $path_parts = pathinfo($fullPath);
        $ext = strtolower($path_parts["extension"]);
        switch ($ext) {
            case "jpg":
            header("Content-type: image/jpg");
            header("Content-Disposition: attachment; filename=\"".$path_parts["basename"]."\""); // use "attachment;" for forcing download rather than just viewing on page - as jpgs and gifs will be displayed if attachment isn't indicated.
            break;
            case "zip":
            header("Content-type: application/zip");
            header("Content-Disposition: filename=\"".$path_parts["basename"]."\"");
            break;
       case "pdf":
            header("Content-type: application/pdf");
            header("Content-Disposition: attachment; filename=\"".$path_parts["basename"]."\"");
            break;
           
        }
        header("Content-length: $fsize");
        header("Cache-control: private");
        while(!feof($fd)) {
            $buffer = fread($fd, 2048);
            echo $buffer;
        }
    }
    fclose ($fd);
    exit;
}

?>

[Free WordPress Themes]

you're sure that the path is fine?
dou you have white space in the begin of the script?

try error reporting...

[Join us @ facebook]

The problem is this :

if (isset($download)) {


$download is not seted anywhere.

took the cue from Nicolas and changed:

if (isset($download)) ===>>  if (isset($_POST['file_in_folder']))

i am not sure if my coding is proper but its running OK ! 

thanks olaf, nicolas, much appreciated.

[Join us @ facebook]

You are welcome

BTW using isset() to determine if the form is posted is not the best way, because if the user post an empty form isset will return true.

You can better use

if ( !empty($_POST['file_in_folder)) )

[Guest]

[36.290]

Googlebot, Yahoo crawler, Baidu Spider, Msnbot